----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26580/#review56263 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/26580/#comment96566> this is non-POD and so can't be statically constructed: http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Static_and_Global_Variables. you could store a list<pthread_t>* or std::unique_ptr<list<pthread_t>> or return a pointer from a function: static list<pthread_t>* workerThreads() { static list<pthread_t> workerThreads; return *workerThreads; } - Dominic Hamon On Oct. 10, 2014, 4:38 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26580/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 4:38 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Terminate the gc; > Finalize the ProcessManager (picking up -idealy 0- left-over processes); > Join on the worker threads that were dispatched. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp 85fb995 > > Diff: https://reviews.apache.org/r/26580/diff/ > > > Testing > ------- > > make check > support/mesos-style.py > > > Thanks, > > Joris Van Remoortere > >
