----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26580/#review56428 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/26580/#comment96716> you don't need the else here, given the 'if' has a FATAL. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/26580/#comment96718> if we have a process with a long-running (infinite) loop will this block shutdown? should we have a timeout here? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/26580/#comment96719> is this really fatal? ie - should we try to continue joining the other threads but log as an error that we failed to join some? - Dominic Hamon On Oct. 13, 2014, 11:26 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26580/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2014, 11:26 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Terminate the gc; > Finalize the ProcessManager (picking up -idealy 0- left-over processes); > Join on the worker threads that were dispatched. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp 85fb995 > > Diff: https://reviews.apache.org/r/26580/diff/ > > > Testing > ------- > > make check > support/mesos-style.py > > > Thanks, > > Joris Van Remoortere > >
