----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26580/#review56426 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/26580/#comment96708> so it turns out i gave you bad advice. i checked, and unique_ptr is also non-POD and thus has static destruction order issues. "If you need a static or global variable of a class type, consider initializing a pointer (which will never be freed), from either your main() function or from pthread_once(). Note that this must be a raw pointer, not a "smart" pointer, since the smart pointer's destructor will have the order-of-destructor issue that we are trying to avoid." (the google c++ style guide). i think this will need to be a raw pointer after all, or an instance variable. - Dominic Hamon On Oct. 13, 2014, 11:10 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26580/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2014, 11:10 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Terminate the gc; > Finalize the ProcessManager (picking up -idealy 0- left-over processes); > Join on the worker threads that were dispatched. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp 85fb995 > > Diff: https://reviews.apache.org/r/26580/diff/ > > > Testing > ------- > > make check > support/mesos-style.py > > > Thanks, > > Joris Van Remoortere > >
