----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26825/#review57081 -----------------------------------------------------------
support/hooks/pre-commit <https://reviews.apache.org/r/26825/#comment97562> Add a comment? # Check that the commits are properly split between mesos, libprocess and stout. support/mesos_split.py <https://reviews.apache.org/r/26825/#comment97563> period at the end. support/mesos_split.py <https://reviews.apache.org/r/26825/#comment97564> s/libraray./library/ support/mesos_split.py <https://reviews.apache.org/r/26825/#comment97565> It's weird that this script talks about commits but takes a list of files. Why not have it take it a commit sha and let it convert to a list of files? support/mesos_split.py <https://reviews.apache.org/r/26825/#comment97566> period. support/mesos_split.py <https://reviews.apache.org/r/26825/#comment97567> How about? "Please use separate commits for mesos, libprocess and stout." support/mesos_split.py <https://reviews.apache.org/r/26825/#comment97568> s/#Find/# Find/ period at the end. support/mesos_split.py <https://reviews.apache.org/r/26825/#comment97569> No need to pull this out into a constant. Just print the string here. - Vinod Kone On Oct. 16, 2014, 9:04 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26825/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 9:04 p.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-1712 and MESOS-1932 > https://issues.apache.org/jira/browse/MESOS-1712 > https://issues.apache.org/jira/browse/MESOS-1932 > > > Repository: mesos-git > > > Description > ------- > > Adds a new script mesos_split.py which is run as a git precommit hook. It > will error if a commit is made which spans across multiple of the mesos > projects (mesos, stout, libprocess) > > Sample output: > ``` > ERROR: Commit spanning multiple projects > > Mesos rules state that a commit should only touch one mesos project (stout, > libprocess, mesos). > > Paths grouped by project: > mesos: > baz > libprocess: > 3rdparty/libprocess/asdf > stout: > 3rdparty/libprocess/3rdparty/stout/foobar > ``` > > > Diffs > ----- > > support/hooks/pre-commit f6910f852a51d64a3441f9c23e70cafc6f7de741 > support/mesos_split.py PRE-CREATION > > Diff: https://reviews.apache.org/r/26825/diff/ > > > Testing > ------- > > Git added files in various groupings of the subprojects. Tried committing, > resulting in the sample error message above. > > > Thanks, > > Cody Maloney > >
