----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26825/#review57768 -----------------------------------------------------------
Looks great. A few minor suggestions/questions, and then I'd call it commit-worthy. Will this also get run by reviewbot somehow? support/mesos_split.py <https://reviews.apache.org/r/26825/#comment98648> Don't you need to have at least 2 filenames for this script to make any sense? support/mesos_split.py <https://reviews.apache.org/r/26825/#comment98647> Maybe make it more explicit how the filenames should be delimited (space) by suggesting "Usage: ./mesos-split.py <filename1> <filename2>..." support/mesos_split.py <https://reviews.apache.org/r/26825/#comment98650> Any reason why "3rdparty/libprocess/" ends in a '/' but stout doesn't? Consistency, please. support/mesos_split.py <https://reviews.apache.org/r/26825/#comment98649> Did you intend to have two spaces before the %s? I would think a single space would be enough. - Adam B On Oct. 21, 2014, 2:20 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26825/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 2:20 p.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-1712 and MESOS-1932 > https://issues.apache.org/jira/browse/MESOS-1712 > https://issues.apache.org/jira/browse/MESOS-1932 > > > Repository: mesos-git > > > Description > ------- > > Adds a new script mesos_split.py which is run as a git precommit hook. It > will error if a commit is made which spans across multiple of the mesos > projects (mesos, stout, libprocess) > > Sample output: > ``` > ERROR: Commit spanning multiple projects > > Mesos rules state that a commit should only touch one mesos project (stout, > libprocess, mesos). > > Paths grouped by project: > mesos: > baz > libprocess: > 3rdparty/libprocess/asdf > stout: > 3rdparty/libprocess/3rdparty/stout/foobar > ``` > > > Diffs > ----- > > support/hooks/pre-commit f6910f852a51d64a3441f9c23e70cafc6f7de741 > support/mesos_split.py PRE-CREATION > > Diff: https://reviews.apache.org/r/26825/diff/ > > > Testing > ------- > > Git added files in various groupings of the subprojects. Tried committing, > resulting in the sample error message above. > > > Thanks, > > Cody Maloney > >
