> On Oct. 22, 2014, 8:44 a.m., Adam B wrote: > > support/mesos_split.py, line 63 > > <https://reviews.apache.org/r/26825/diff/2/?file=728014#file728014line63> > > > > Did you intend to have two spaces before the %s? I would think a single > > space would be enough.
The goal is that they are visibly indented. One would probably work, I went with two since that is our standard indent. > On Oct. 22, 2014, 8:44 a.m., Adam B wrote: > > support/mesos_split.py, line 27 > > <https://reviews.apache.org/r/26825/diff/2/?file=728014#file728014line27> > > > > Don't you need to have at least 2 filenames for this script to make any > > sense? A commit can contain just a single file, and the script needs to function correctly in that case. > On Oct. 22, 2014, 8:44 a.m., Adam B wrote: > > support/mesos_split.py, line 28 > > <https://reviews.apache.org/r/26825/diff/2/?file=728014#file728014line28> > > > > Maybe make it more explicit how the filenames should be delimited > > (space) by suggesting "Usage: ./mesos-split.py <filename1> <filename2>..." The angle bracket notation is fairly standard. git add --help: git add [-n] [-v] [--force | -f] [--interactive | -i] [--patch | -p] [--edit | -e] [--[no-]all | --[no-]ignore-removal | [--update | -u]] [--intent-to-add | -N] [--refresh] [--ignore-errors] [--ignore-missing] [--] [<pathspec>...] man ls: ls [-ABCFGHLOPRSTUW@abcdefghiklmnopqrstuwx1] [file ...] g++ --help: Usage: g++ [options] file... - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26825/#review57768 ----------------------------------------------------------- On Oct. 23, 2014, 5:17 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26825/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2014, 5:17 p.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-1712 and MESOS-1932 > https://issues.apache.org/jira/browse/MESOS-1712 > https://issues.apache.org/jira/browse/MESOS-1932 > > > Repository: mesos-git > > > Description > ------- > > Adds a new script mesos_split.py which is run as a git precommit hook. It > will error if a commit is made which spans across multiple of the mesos > projects (mesos, stout, libprocess) > > Sample output: > ``` > ERROR: Commit spanning multiple projects > > Mesos rules state that a commit should only touch one mesos project (stout, > libprocess, mesos). > > Paths grouped by project: > mesos: > baz > libprocess: > 3rdparty/libprocess/asdf > stout: > 3rdparty/libprocess/3rdparty/stout/foobar > ``` > > > Diffs > ----- > > support/hooks/pre-commit f6910f852a51d64a3441f9c23e70cafc6f7de741 > support/mesos_split.py PRE-CREATION > > Diff: https://reviews.apache.org/r/26825/diff/ > > > Testing > ------- > > Git added files in various groupings of the subprojects. Tried committing, > resulting in the sample error message above. > > > Thanks, > > Cody Maloney > >
