----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26775/#review57192 -----------------------------------------------------------
Looks like you changed more than just loading flags (hoisting flags parsing out of the slave look for example). Mind mention those in the RR description? src/local/local.cpp <https://reviews.apache.org/r/26775/#comment97727> Wouldn't protobuf's MergeFrom() work here? That would simplify this patch a bit src/local/local.cpp <https://reviews.apache.org/r/26775/#comment97726> Why this change? src/local/local.cpp <https://reviews.apache.org/r/26775/#comment97728> Do you need to change this? - Niklas Nielsen On Oct. 15, 2014, 2:07 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26775/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 2:07 p.m.) > > > Review request for mesos, Kapil Arya and Niklas Nielsen. > > > Bugs: MESOS-1927 > https://issues.apache.org/jira/browse/MESOS-1927 > > > Repository: mesos-git > > > Description > ------- > > Frameworks triggering a local cluster (--master=local) now have module > loading support via slave and master flags (--modules). Duplicate modules > (slave vs. master) are filtered before loading. > > > Diffs > ----- > > src/local/local.cpp 66de798 > > Diff: https://reviews.apache.org/r/26775/diff/ > > > Testing > ------- > > make check & functional check using upcoming module related patches. > > > Thanks, > > Till Toenshoff > >
