> On Oct. 18, 2014, 7:37 p.m., Kapil Arya wrote: > > src/local/local.cpp, lines 174-186 > > <https://reviews.apache.org/r/26775/diff/1/?file=722599#file722599line174> > > > > Would it make sense to change ModuleManager::load() to allow multiple > > calls? If that works, we won't need to mergeModules at all.
I guess I was taking too much care here :) .... thanks - indeed, why not. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26775/#review57279 ----------------------------------------------------------- On Oct. 15, 2014, 9:07 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26775/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 9:07 p.m.) > > > Review request for mesos, Kapil Arya and Niklas Nielsen. > > > Bugs: MESOS-1927 > https://issues.apache.org/jira/browse/MESOS-1927 > > > Repository: mesos-git > > > Description > ------- > > Frameworks triggering a local cluster (--master=local) now have module > loading support via slave and master flags (--modules). Duplicate modules > (slave vs. master) are filtered before loading. > > > Diffs > ----- > > src/local/local.cpp 66de798 > > Diff: https://reviews.apache.org/r/26775/diff/ > > > Testing > ------- > > make check & functional check using upcoming module related patches. > > > Thanks, > > Till Toenshoff > >
