----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26775/#review57279 -----------------------------------------------------------
src/local/local.cpp <https://reviews.apache.org/r/26775/#comment97831> Can we use something like: foreach (const Modules::Library& library, modules.libraries()) { And then: foreach (const string& moduleName, library.modules()) { I am not sure what the preference is over using foreach vs a for loop src/local/local.cpp <https://reviews.apache.org/r/26775/#comment97832> The library now has an optional "name" field as well. src/local/local.cpp <https://reviews.apache.org/r/26775/#comment97833> Same as above - handle "name" field. src/local/local.cpp <https://reviews.apache.org/r/26775/#comment97834> Same as above -- handle "name" field. src/local/local.cpp <https://reviews.apache.org/r/26775/#comment97836> Would it make sense to change ModuleManager::load() to allow multiple calls? If that works, we won't need to mergeModules at all. - Kapil Arya On Oct. 15, 2014, 5:07 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26775/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 5:07 p.m.) > > > Review request for mesos, Kapil Arya and Niklas Nielsen. > > > Bugs: MESOS-1927 > https://issues.apache.org/jira/browse/MESOS-1927 > > > Repository: mesos-git > > > Description > ------- > > Frameworks triggering a local cluster (--master=local) now have module > loading support via slave and master flags (--modules). Duplicate modules > (slave vs. master) are filtered before loading. > > > Diffs > ----- > > src/local/local.cpp 66de798 > > Diff: https://reviews.apache.org/r/26775/diff/ > > > Testing > ------- > > make check & functional check using upcoming module related patches. > > > Thanks, > > Till Toenshoff > >
