> On Oct. 22, 2014, 12:23 p.m., Niklas Nielsen wrote: > > src/module/manager.hpp, line 69 > > <https://reviews.apache.org/r/26906/diff/7/?file=728686#file728686line69> > > > > Why this change? because of 'kind<Kind>'?
Yeah, it was getting confusing and harder to read. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26906/#review57808 ----------------------------------------------------------- On Oct. 22, 2014, 4:04 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26906/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 4:04 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Since, there is no reliable method of converting a template type to a > string, we create an temporary object of the given kind and compare the > "kind" fields of the temporary object with that of the one being > created. > > > Diffs > ----- > > include/mesos/module.hpp 5205e30c7b8228eced9793aef2348930180811bb > src/examples/test_module.hpp b5cc2fa9147c4fe9a1f2eb3e8c2c2565ea7f7420 > src/module/manager.hpp 1c93ac4707e3c5dc8acaaa23861b62d3d3921125 > src/tests/module_tests.cpp e92d8717427e259b1fa26b3f17719fd616a748c7 > > Diff: https://reviews.apache.org/r/26906/diff/ > > > Testing > ------- > > Added a new test and ran make check. > > > Thanks, > > Kapil Arya > >
