> On Oct. 23, 2014, 6:58 p.m., Ben Mahler wrote: > > src/linux/ns.hpp, line 65 > > <https://reviews.apache.org/r/27091/diff/2/?file=731817#file731817line65> > > > > s/ns/namespace/ for the argument
I'd like to avoid using the reserved word 'namespace' in code, event for argument names. > On Oct. 23, 2014, 6:58 p.m., Ben Mahler wrote: > > src/linux/ns.hpp, line 119 > > <https://reviews.apache.org/r/27091/diff/2/?file=731817#file731817line119> > > > > s/ns/namespace/ for the argument I'd like to avoid using the reserved word 'namespace' in code, event for argument names. > On Oct. 23, 2014, 6:58 p.m., Ben Mahler wrote: > > src/linux/ns.hpp, lines 63-65 > > <https://reviews.apache.org/r/27091/diff/2/?file=731817#file731817line63> > > > > Looks like this can be hidden in an 'internal' namespace? Ideally yes, but it's used in tests. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27091/#review58201 ----------------------------------------------------------- On Oct. 24, 2014, 2:53 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27091/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 2:53 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > A following commit will remove this code from stout. > > > Diffs > ----- > > src/Makefile.am 2617f77b757cb7414889520c88b1bc203dedef09 > src/linux/ns.hpp PRE-CREATION > src/slave/containerizer/isolators/network/port_mapping.cpp > 62ca9bca08de55f19bfff7b8828dfa4fb6c51f30 > src/tests/ns_tests.cpp PRE-CREATION > src/tests/setns_test_helper.hpp PRE-CREATION > src/tests/setns_test_helper.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/27091/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
