----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/#review59308 -----------------------------------------------------------
Ship it! A few minor re-wordings, then we can commit it! src/master/flags.hpp <https://reviews.apache.org/r/26859/#comment100577> Update this comment to match the actually accepted inputs. No longer can there be multiple authenticators or even a comma. Suggested new text: "Authenticator implementation to use when authenticating frameworks and/or slaves. Use the default '" + DEFAULT_AUTHENTICATOR + "', or load an alternate authenticator module using --modules." src/master/master.cpp <https://reviews.apache.org/r/26859/#comment100579> These TODOs are probably obvious enough you could remove them. If/when we support multiple authenticators, this is the first place we'll have to change the code, and the EXIT error makes that obvious. :) src/master/master.cpp <https://reviews.apache.org/r/26859/#comment100580> I'd add single quotes (') around the default authenticator name, so it reads "(compare to 'crammd5')" src/master/master.cpp <https://reviews.apache.org/r/26859/#comment100581> "... verify that the authenticator module was loaded successfully (see --modules)" - Adam B On Oct. 30, 2014, 6:37 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26859/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 6:37 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1889 > https://issues.apache.org/jira/browse/MESOS-1889 > > > Repository: mesos-git > > > Description > ------- > > Enables selecting a module based authenticator via the new --authenticators > flag for mesos master. > > Additionally, all "> >" have been fixed towards ">>" in master.hpp and > master.cpp. > > > Diffs > ----- > > src/master/constants.hpp a8298bc > src/master/constants.cpp 3ebd246 > src/master/flags.hpp c931fd9 > src/master/master.hpp b1a2cd0 > src/master/master.cpp 762d2ff > src/tests/cram_md5_authentication_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/26859/diff/ > > > Testing > ------- > > make check > > NOTE all four CRAM-MD5 authenticator module related RRs need to get applied > before running make check. > > > Thanks, > > Till Toenshoff > >
