> On Oct. 31, 2014, 12:43 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 124 > > <https://reviews.apache.org/r/26859/diff/7/?file=741143#file741143line124> > > > > i wish you did this cleanup as a dependent patch. oh well.
That indeed would have been better - sry for the inconvenience caused. > On Oct. 31, 2014, 12:43 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 386 > > <https://reviews.apache.org/r/26859/diff/7/?file=741143#file741143line386> > > > > Do you also want to specify how to specify the modules, e.g., "via > > --modules flag"? Seems you were looking at an older RR - the latest one used the following: EXIT(1) << "Authenticator '" << authenticatorNames[0] << "' not found." << "Check the spelling (compare to " << BUILTIN_AUTHENTICATOR_NAME << ") or verify that the " << "authenticator was loaded from a module (see --modules)"; - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/#review59108 ----------------------------------------------------------- On Oct. 30, 2014, 11:58 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26859/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 11:58 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1889 > https://issues.apache.org/jira/browse/MESOS-1889 > > > Repository: mesos-git > > > Description > ------- > > Enables selecting a module based authenticator via the new --authenticators > flag for mesos master. > > Additionally, all "> >" have been fixed towards ">>" in master.hpp and > master.cpp. > > > Diffs > ----- > > src/master/constants.hpp a8298bc > src/master/constants.cpp 3ebd246 > src/master/flags.hpp c931fd9 > src/master/master.hpp b1a2cd0 > src/master/master.cpp 762d2ff > src/tests/cram_md5_authentication_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/26859/diff/ > > > Testing > ------- > > make check > > NOTE all four CRAM-MD5 authenticator module related RRs need to get applied > before running make check. > > > Thanks, > > Till Toenshoff > >
