----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/#review59108 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/26859/#comment100425> i wish you did this cleanup as a dependent patch. oh well. src/master/master.cpp <https://reviews.apache.org/r/26859/#comment100426> Why not just EXIT if we don't support multiple modules? src/master/master.cpp <https://reviews.apache.org/r/26859/#comment100427> Do you also want to specify how to specify the modules, e.g., "via --modules flag"? - Vinod Kone On Oct. 30, 2014, 11:58 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26859/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 11:58 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1889 > https://issues.apache.org/jira/browse/MESOS-1889 > > > Repository: mesos-git > > > Description > ------- > > Enables selecting a module based authenticator via the new --authenticators > flag for mesos master. > > Additionally, all "> >" have been fixed towards ">>" in master.hpp and > master.cpp. > > > Diffs > ----- > > src/master/constants.hpp a8298bc > src/master/constants.cpp 3ebd246 > src/master/flags.hpp c931fd9 > src/master/master.hpp b1a2cd0 > src/master/master.cpp 762d2ff > src/tests/cram_md5_authentication_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/26859/diff/ > > > Testing > ------- > > make check > > NOTE all four CRAM-MD5 authenticator module related RRs need to get applied > before running make check. > > > Thanks, > > Till Toenshoff > >
