> On Nov. 6, 2014, 6 a.m., Adam B wrote: > > src/authentication/cram_md5/authenticatee.hpp, lines 78-79 > > <https://reviews.apache.org/r/27493/diff/1/?file=746988#file746988line78> > > > > Why the change in wrapping? I think it would still fit the other way, > > and if you are bringing credential down to the next line, it might be > > better if you give the UPID its own line too.
True, messed that up -- will add some clang-format love. > On Nov. 6, 2014, 6 a.m., Adam B wrote: > > src/examples/test_authentication_module.cpp, line 1 > > <https://reviews.apache.org/r/27493/diff/1/?file=746989#file746989line1> > > > > Maybe this file should be "test_authentication_modules.cpp" (plural) > > since it contains multiple modules? Totally, yes - we should also make Kapil aware of this change as the isolator modules should in fact also use this plural. > On Nov. 6, 2014, 6 a.m., Adam B wrote: > > src/authentication/cram_md5/authenticatee.hpp, line 418 > > <https://reviews.apache.org/r/27493/diff/1/?file=746988#file746988line418> > > > > "requires a credential" (singular)? Yes, thank you. > On Nov. 6, 2014, 6 a.m., Adam B wrote: > > src/authentication/cram_md5/authenticatee.hpp, line 80 > > <https://reviews.apache.org/r/27493/diff/1/?file=746988#file746988line80> > > > > s/authenticatee/crammd5_authenticatee/ Initially I thought about doing so -- then I (falsely) turned it down as I had in mind that we would never have multiple, distinct authenticatee mechanism processes running. Certainly not true given that we plan to allow framework- and slave-authentication to freely choose their individual mechanisms. Thanks for this comment. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27493/#review60124 ----------------------------------------------------------- On Nov. 5, 2014, 4:24 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27493/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 4:24 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, and Vinod Kone. > > > Bugs: MESOS-2001 > https://issues.apache.org/jira/browse/MESOS-2001 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/Makefile.am 2d72a70 > src/authentication/authenticatee.hpp PRE-CREATION > src/authentication/cram_md5/authenticatee.hpp PRE-CREATION > src/examples/test_authentication_module.cpp PRE-CREATION > src/examples/test_authenticator_module.cpp PRE-CREATION > src/module/authenticatee.hpp PRE-CREATION > src/module/manager.cpp 7a6c884 > > Diff: https://reviews.apache.org/r/27493/diff/ > > > Testing > ------- > > make check > > Note: All three CRAM-MD5 Authenticatee patches need to get applied before > running make check! > > > Thanks, > > Till Toenshoff > >
