----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27493/#review60837 -----------------------------------------------------------
src/authentication/cram_md5/authenticatee.hpp <https://reviews.apache.org/r/27493/#comment102241> C headers should come first. src/authentication/cram_md5/authenticatee.hpp <https://reviews.apache.org/r/27493/#comment102242> virtual Try<Nothin> initialize( const process::UPID& clientPid, const Credential& credential); Also, why introduce initialize()? src/authentication/cram_md5/authenticatee.hpp <https://reviews.apache.org/r/27493/#comment102243> why the factory method? - Vinod Kone On Nov. 10, 2014, 1:50 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27493/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 1:50 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, and Vinod Kone. > > > Bugs: MESOS-2001 > https://issues.apache.org/jira/browse/MESOS-2001 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/Makefile.am 443554a > src/authentication/authenticatee.hpp PRE-CREATION > src/authentication/cram_md5/authenticatee.hpp 3088a77 > src/examples/test_authentication_modules.cpp PRE-CREATION > src/examples/test_authenticator_module.cpp 4398d71 > src/module/authenticatee.hpp PRE-CREATION > src/module/manager.cpp 0d71e33 > > Diff: https://reviews.apache.org/r/27493/diff/ > > > Testing > ------- > > make check > > Note: All three CRAM-MD5 Authenticatee patches need to get applied before > running make check! > > > Thanks, > > Till Toenshoff > >
