> On Nov. 6, 2014, 1:33 p.m., Kapil Arya wrote: > > src/authentication/authenticatee.hpp, lines 19-20 > > <https://reviews.apache.org/r/27493/diff/2/?file=751526#file751526line19> > > > > Don't we want to put the directory name in it as well?
We decided against it for authentication/authenticator.hpp, since it's pretty redundant, like master/master.hpp or files/files.hpp; and it's not likely that we'll have another Authenticatee at the root scope. If you feel at all strongly about it, I wouldn't fight it, but I would ask that we make the same change to authenticator.hpp. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27493/#review60244 ----------------------------------------------------------- On Nov. 6, 2014, 2:33 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27493/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 2:33 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, and Vinod Kone. > > > Bugs: MESOS-2001 > https://issues.apache.org/jira/browse/MESOS-2001 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/Makefile.am 9ab3b9c > src/authentication/authenticatee.hpp PRE-CREATION > src/authentication/cram_md5/authenticatee.hpp 3088a77 > src/examples/test_authentication_modules.cpp PRE-CREATION > src/examples/test_authenticator_module.cpp 4398d71 > src/module/authenticatee.hpp PRE-CREATION > src/module/manager.cpp 0d71e33 > > Diff: https://reviews.apache.org/r/27493/diff/ > > > Testing > ------- > > make check > > Note: All three CRAM-MD5 Authenticatee patches need to get applied before > running make check! > > > Thanks, > > Till Toenshoff > >
