> On Nov. 10, 2014, 1:01 p.m., Cody Maloney wrote: > > 3rdparty/libprocess/include/process/future.hpp, line 1180 > > <https://reviews.apache.org/r/27826/diff/1/?file=757056#file757056line1180> > > > > If this return by const ref either object message field or a default > > empty string is going to be even moderately common we should pull the empty > > string into <stout/strings> and add a helper `const std::string > > &returnConstRefString(const std:string* str)` which has the null checking > > logic in it.
adding a TODO. I'm not convinced the pattern is that common. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27826/#review60670 ----------------------------------------------------------- On Nov. 10, 2014, 1:12 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27826/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 1:12 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1694 > https://issues.apache.org/jira/browse/MESOS-1694 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf > > Diff: https://reviews.apache.org/r/27826/diff/ > > > Testing > ------- > > make check. > manual review of calling code. > > > Thanks, > > Dominic Hamon > >
