----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27826/#review60686 -----------------------------------------------------------
Sounds good, I think we should first get rid of the empty string case though. 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/27826/#comment102064> Can we avoid the need for this with a separate change to use ABORT when failure() is called on a non-failed future? Much like we do for try, result, option. - Ben Mahler On Nov. 10, 2014, 9:12 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27826/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 9:12 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1694 > https://issues.apache.org/jira/browse/MESOS-1694 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf > > Diff: https://reviews.apache.org/r/27826/diff/ > > > Testing > ------- > > make check. > manual review of calling code. > > > Thanks, > > Dominic Hamon > >
