> On Dec. 3, 2014, 8:09 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/libevent_poll.cpp, lines 27-28 > > <https://reviews.apache.org/r/28323/diff/3/?file=781921#file781921line27> > > > > I have a bit of a hard time understanding this - can you expand/comment > > on what's going on?
Since the enumerations for READ / WRITE are different in io.hpp and libevent, we need to do a conversion. See: https://github.com/libevent/libevent/blob/master/include/event2/event.h#L920 vs. io.hpp#L15 - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28323/#review63719 ----------------------------------------------------------- On Dec. 3, 2014, 11:27 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28323/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 11:27 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/src/libevent_poll.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28323/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
