----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28670/#review63923 -----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28670/#comment106261> s/SocketKind/Kind/ 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28670/#comment106336> We should make the 'kind' default too! 3rdparty/libprocess/src/poll_socket.cpp <https://reviews.apache.org/r/28670/#comment106334> s/socket:"/socket: "/ 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28670/#comment106332> s/serverSocket/create/ 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28670/#comment106266> = None(); 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28670/#comment106265> s/sock/create/ The pattern is to use the function name rather than introduce lots of slightly differing variable names. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28670/#comment106262> CHECK_SOME(socket); 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28670/#comment106263> Socket(socket.get()).connect(to.node) // Create copy to remove const. Please do this below too. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28670/#comment106264> s/connectSocket/socket.get()/ 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28670/#comment106267> = None(); 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28670/#comment106268> s/sock/create/ 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28670/#comment106270> See comments above. 3rdparty/libprocess/src/socket.cpp <https://reviews.apache.org/r/28670/#comment106339> Can we not introduce this until we actually need to use it? 3rdparty/libprocess/src/socket.cpp <https://reviews.apache.org/r/28670/#comment106338> No default? We should at least have an ABORT after the switch statement. - Benjamin Hindman On Dec. 3, 2014, 7:57 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28670/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 7:57 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-2109 > https://issues.apache.org/jira/browse/MESOS-2109 > > > Repository: mesos-git > > > Description > ------- > > Add a factory pattern to allow construction of different implementations of > the socket interface. Remove default constructor from Socket. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/include/process/socket.hpp > 3f3e01c7e9ecc52042c432212f697b69b3fde3b0 > 3rdparty/libprocess/src/poll_socket.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 > 3rdparty/libprocess/src/socket.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/decoder_tests.cpp > 04ca3ff530ee54ae63e792619aa0971c61b54eeb > > Diff: https://reviews.apache.org/r/28670/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
