Re: Review Request 28670: Add a factory pattern to allow construction of different implementations of the socket interface. Remove default constructor from Socket.

Thu, 18 Dec 2014 16:26:31 -0800 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28670/
-----------------------------------------------------------

(Updated Dec. 19, 2014, 12:25 a.m.)


Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Changes
-------

Rebase. Add comments.


Bugs: MESOS-2109
    https://issues.apache.org/jira/browse/MESOS-2109


Repository: mesos-git


Description
-------

Add a factory pattern to allow construction of different implementations of the 
socket interface. Remove default constructor from Socket.


Diffs (updated)
-----

  3rdparty/libprocess/Makefile.am 75870ac754e500bb4ca689201bde677fa7d854d0 
  3rdparty/libprocess/include/process/socket.hpp 
7e1e3f22583f44a9aea8259bafedc2877ad2e633 
  3rdparty/libprocess/src/poll_socket.cpp PRE-CREATION 
  3rdparty/libprocess/src/process.cpp 028b33e7ecb7e0a39334ac4ab0279ee327a72a56 
  3rdparty/libprocess/src/socket.cpp PRE-CREATION 
  3rdparty/libprocess/src/tests/decoder_tests.cpp 
ef52798fa238db0612df73657b86ee1631c688bf 

Diff: https://reviews.apache.org/r/28670/diff/


Testing
-------


Thanks,

Joris Van Remoortere

Reply via email to