> On Dec. 5, 2014, 5:46 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/socket.cpp, lines 53-57 > > <https://reviews.apache.org/r/28670/diff/1/?file=781930#file781930line53> > > > > No default? We should at least have an ABORT after the switch statement.
Added a comment explaining the nice compiler behavior we get without a default provided (as discussed). - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28670/#review63923 ----------------------------------------------------------- On Dec. 5, 2014, 7:53 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28670/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 7:53 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-2109 > https://issues.apache.org/jira/browse/MESOS-2109 > > > Repository: mesos-git > > > Description > ------- > > Add a factory pattern to allow construction of different implementations of > the socket interface. Remove default constructor from Socket. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/include/process/socket.hpp > 3f3e01c7e9ecc52042c432212f697b69b3fde3b0 > 3rdparty/libprocess/src/poll_socket.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 > 3rdparty/libprocess/src/socket.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/decoder_tests.cpp > 04ca3ff530ee54ae63e792619aa0971c61b54eeb > > Diff: https://reviews.apache.org/r/28670/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
