----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28716/#review64017 -----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28716/#comment106400> can you try removing the explicit std::string constructor? it shouldn't be necessary as the rhs of the + is a std::string. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28716/#comment106402> include the node in the error message please 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28716/#comment106401> include the node in the error message please 3rdparty/libprocess/src/net.hpp <https://reviews.apache.org/r/28716/#comment106403> that += seems weird. this should be: throw runtime_error("socket: " + trySocket.error()); i think! 3rdparty/libprocess/src/net.hpp <https://reviews.apache.org/r/28716/#comment106404> throw runtime_error(tryAccept.error()); right? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28716/#comment106405> maybe this would read easier if the condition was reversed: if (errno == EINPROGRESS) { return io::poll(get(), io::WRITE) .then(lambda::bind(&internal::connect, Socket(shared_from_this()))); } return Failure(tryConnect.error()); so it's clear that we're trying again if it's 'in progress' but failing otherwise. what do you think? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28716/#comment106406> return tryBind.error(); - Dominic Hamon On Dec. 5, 2014, 9:11 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28716/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 9:11 a.m.) > > > Review request for mesos and Dominic Hamon. > > > Repository: mesos-git > > > Description > ------- > > Created accept, bind, connect and getsockname wrappers in socket.hpp for > different protocol families > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > ab080c154095029c4a01d189a5fd8a178ba6c92e > 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358 > 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e > 3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713 > 3rdparty/libprocess/src/process.cpp > 4db7d56af710577e08a9d7dbeb92a1f01559401f > 3rdparty/libprocess/src/tests/http_tests.cpp > a90e65f77904da0a45e1cc0cc9889ae69354a1a5 > 3rdparty/libprocess/src/tests/process_tests.cpp > dec62e88ec993433e1a0777593bb2657b43636dc > > Diff: https://reviews.apache.org/r/28716/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
