----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28716/#review64146 -----------------------------------------------------------
Thanks Evelina and Dominic! I don't have the context on this change, but there are a few general code quality items that were missed in review :( Could you please follow up on them? Thank you! 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28716/#comment106594> Hm.. this comment is a bit odd, because it's on top of the first method, but not on top of the others. Mind removing it, or adding something more standalone (i.e. newline): ``` // Socket call wrappers for different address families. inline ... ``` 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28716/#comment106595> How about s/s/socket/ given this is an interface, and we'd like to express the meaning of 's' to the _caller_. In the other cases, we're calling a socket 's' in the _callee_, which is ok. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28716/#comment106593> What does 'rc' mean? :) Please just call it 'accept' or 'result', it's ok to hide the name in the former case. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28716/#comment106591> Looks like the lack of braces here was missed. 3rdparty/libprocess/src/http.cpp <https://reviews.apache.org/r/28716/#comment106596> The pattern we use for succinctness and clarity in naming here is: ``` Try<int> connect = process::connect(...); ``` "try" is redundant here since it's encoded in the type. Ditto everywhere else. :) - Ben Mahler On Dec. 5, 2014, 9:21 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28716/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 9:21 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-2177 > https://issues.apache.org/jira/browse/MESOS-2177 > > > Repository: mesos-git > > > Description > ------- > > Created accept, bind, connect and getsockname wrappers in socket.hpp for > different protocol families > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > ab080c154095029c4a01d189a5fd8a178ba6c92e > 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358 > 3rdparty/libprocess/src/process.cpp > 4db7d56af710577e08a9d7dbeb92a1f01559401f > 3rdparty/libprocess/src/tests/http_tests.cpp > a90e65f77904da0a45e1cc0cc9889ae69354a1a5 > 3rdparty/libprocess/src/tests/process_tests.cpp > dec62e88ec993433e1a0777593bb2657b43636dc > > Diff: https://reviews.apache.org/r/28716/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
