-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28716/
-----------------------------------------------------------

(Updated Dec. 5, 2014, 8:31 p.m.)


Review request for mesos and Dominic Hamon.


Changes
-------

Removed the explicit std::string constructor and included the node in the error 
message for bind & connect methods.
Reversed the condition from if statement in the connect method from process.cpp.
Temporary dropped changes for 3rdparty/libprocess/src/net.hpp and 
3rdparty/libprocess/src/httpd.cpp because this code is not been compiled at all.


Repository: mesos-git


Description
-------

Created accept, bind, connect and getsockname wrappers in socket.hpp for 
different protocol families


Diffs (updated)
-----

  3rdparty/libprocess/include/process/socket.hpp 
ab080c154095029c4a01d189a5fd8a178ba6c92e 
  3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358 
  3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f 
  3rdparty/libprocess/src/tests/http_tests.cpp 
a90e65f77904da0a45e1cc0cc9889ae69354a1a5 
  3rdparty/libprocess/src/tests/process_tests.cpp 
dec62e88ec993433e1a0777593bb2657b43636dc 

Diff: https://reviews.apache.org/r/28716/diff/


Testing
-------

make check


Thanks,

Evelina Dumitrescu

Reply via email to