----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28656/#review64106 -----------------------------------------------------------
You need to rebase both. That should also give you the Labels Message. General comment - let's split the task label and environment decorators into their own reviews. We need to think carefully about where to do the decorator placement and how decorators can _remove_ fields. As you mentioned in the previous RR; we need tests to go along with it. src/hook/hook.hpp <https://reviews.apache.org/r/28656/#comment106541> We need to separate these into task label vs environment decorator ones. src/hook/manager.hpp <https://reviews.apache.org/r/28656/#comment106547> Please disregard my other comment on the whole enum, but I am still wondering what you are using NUM_HOOKS for? src/hook/manager.cpp <https://reviews.apache.org/r/28656/#comment106543> s/newEnvironment/result/g? src/slave/slave.cpp <https://reviews.apache.org/r/28656/#comment106544> Can we move this further down - maybe as one of the last statements? src/slave/slave.cpp <https://reviews.apache.org/r/28656/#comment106546> Why do we need this split? I know that we talked about this, if we used the hooks object to do both pre and post actions. We are not doing that anymore, so I would try not to make that split. - Niklas Nielsen On Dec. 3, 2014, 10:15 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28656/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 10:15 a.m.) > > > Review request for mesos and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Similar to Master hooks. > > > Diffs > ----- > > src/hook/hook.hpp PRE-CREATION > src/hook/manager.hpp PRE-CREATION > src/hook/manager.cpp PRE-CREATION > src/slave/flags.hpp fee79e04cca14e136241af06af1fa9105a70b6dd > src/slave/main.cpp 087944aab56685b53772491de39b373ecacd6c57 > src/slave/slave.hpp c6d11ef2de77738ab46d7ca02778f7237d230a5c > src/slave/slave.cpp 373c8b44f5bc000da801b0925e1a9c346d9ffabf > > Diff: https://reviews.apache.org/r/28656/diff/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
