> On Jan. 6, 2015, 8:38 a.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, line 3969 > > <https://reviews.apache.org/r/28656/diff/4/?file=803961#file803961line3969> > > > > Why this refactor? Couldn't you just inline the hook like in the master?
With master label decorator, the merging of labels was done explicitely. However, in this case, the executorInfo is used to create the Executor object and we don't do any explicit merging of environment variables. Further, the refactor is required to presever the constness of the executorInfo variable. If we give up on the constness, we can remove this indirection. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28656/#review66814 ----------------------------------------------------------- On Jan. 13, 2015, 1:24 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28656/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 1:24 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-2060 > https://issues.apache.org/jira/browse/MESOS-2060 > > > Repository: mesos-git > > > Description > ------- > > Similar to label decorator for Master. > > > Diffs > ----- > > src/hook/hook.hpp PRE-CREATION > src/hook/manager.hpp PRE-CREATION > src/hook/manager.cpp PRE-CREATION > src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6 > src/slave/main.cpp 2ff2b0d186dd63e1437956e98e3682d83f2f5cd6 > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d > > Diff: https://reviews.apache.org/r/28656/diff/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
