> On Dec. 5, 2014, 6:01 p.m., Niklas Nielsen wrote: > > src/hook/hook.hpp, lines 36-38 > > <https://reviews.apache.org/r/28656/diff/1/?file=781781#file781781line36> > > > > We need to separate these into task label vs environment decorator ones.
Added https://reviews.apache.org/r/28875/ > On Dec. 5, 2014, 6:01 p.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, line 3836 > > <https://reviews.apache.org/r/28656/diff/1/?file=781787#file781787line3836> > > > > Why do we need this split? I know that we talked about this, if we used > > the hooks object to do both pre and post actions. We are not doing that > > anymore, so I would try not to make that split. The split is good as we can retain the "const"ness of the incoming arguments. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28656/#review64106 ----------------------------------------------------------- On Dec. 9, 2014, 5:21 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28656/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 5:21 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Similar to label decorator for Master. > > > Diffs > ----- > > src/hook/hook.hpp PRE-CREATION > src/hook/manager.hpp PRE-CREATION > src/hook/manager.cpp PRE-CREATION > src/slave/flags.hpp 670997dc3a702cd5edf33f2e5824c5e4dfe4ecef > src/slave/main.cpp 087944aab56685b53772491de39b373ecacd6c57 > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b > > Diff: https://reviews.apache.org/r/28656/diff/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
