----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28815/#review64317 -----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp <https://reviews.apache.org/r/28815/#comment106957> Not needed? src/tests/hierarchical_allocator_tests.cpp <https://reviews.apache.org/r/28815/#comment106958> Not needed? src/tests/hierarchical_allocator_tests.cpp <https://reviews.apache.org/r/28815/#comment106956> Not needed? src/tests/hierarchical_allocator_tests.cpp <https://reviews.apache.org/r/28815/#comment106955> Can you move this function below TearDown. src/tests/hierarchical_allocator_tests.cpp <https://reviews.apache.org/r/28815/#comment106954> See my comments in the last review. You are simulating a process here. You probaly wanna just create a libprocess Process to leverage helpers like FUTURE_DISPATCH, etc. - Jie Yu On Dec. 8, 2014, 10:10 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28815/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 10:10 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Now that the allocator can be unit tested (r/28814), this adds the unit test > base calss, and moves over the DRF test to a unit test. > > > Diffs > ----- > > src/Makefile.am 86161fe7a8bdd86958d24adb74d434cd92d7dfb8 > src/tests/allocator_tests.cpp 65f05fd3a7c7ed6a667e278edecc234cfa99f517 > src/tests/hierarchical_allocator_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28815/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
