> On Dec. 8, 2014, 11:59 p.m., Jie Yu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 28 > > <https://reviews.apache.org/r/28815/diff/1/?file=785782#file785782line28> > > > > Not needed?
Thanks! I had these when I originally re-implemented process::Queue unknowingly. :) > On Dec. 8, 2014, 11:59 p.m., Jie Yu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 126-136 > > <https://reviews.apache.org/r/28815/diff/1/?file=785782#file785782line126> > > > > See my comments in the last review. You are simulating a process here. > > You probaly wanna just create a libprocess Process to leverage helpers like > > FUTURE_DISPATCH, etc. Dropped, per https://reviews.apache.org/r/28814/, since I think we may want to expose a "Stream" of allocations in the allocator interface, rather than a callback. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28815/#review64317 ----------------------------------------------------------- On Dec. 11, 2014, 2:48 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28815/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 2:48 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Now that the allocator can be unit tested (r/28814), this adds the unit test > base calss, and moves over the DRF test to a unit test. > > > Diffs > ----- > > src/Makefile.am 86161fe7a8bdd86958d24adb74d434cd92d7dfb8 > src/tests/allocator_tests.cpp 8626362e5d45304a4800a807d5171178e457ff53 > src/tests/hierarchical_allocator_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28815/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
