> On Dec. 8, 2014, 10:20 p.m., Dominic Hamon wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 141 > > <https://reviews.apache.org/r/28815/diff/1/?file=785782#file785782line141> > > > > std::unique_ptr or, even better, value types. > > > > SetUp is actually called right after the constructor, and the test > > fixture is constructed anew for each test, so initializing these in the > > constructor as value types is cleaner but doesn't affect functionality.
Ah, I misunderstood SetUp! Looks like we're misusing it in a number of places, according to the FAQ: https://code.google.com/p/googletest/wiki/FAQ#Should_I_use_the_constructor/destructor_of_the_test_fixture_or_t Will remove them, thanks! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28815/#review64295 ----------------------------------------------------------- On Dec. 11, 2014, 2:48 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28815/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 2:48 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Now that the allocator can be unit tested (r/28814), this adds the unit test > base calss, and moves over the DRF test to a unit test. > > > Diffs > ----- > > src/Makefile.am 86161fe7a8bdd86958d24adb74d434cd92d7dfb8 > src/tests/allocator_tests.cpp 8626362e5d45304a4800a807d5171178e457ff53 > src/tests/hierarchical_allocator_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28815/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
