> On Dec. 13, 2014, 1:21 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 1804 > > <https://reviews.apache.org/r/28720/diff/2/?file=783822#file783822line1804> > > > > It's interesting to compare this to state::Variable's mutate() method, > > perhaps we should call this transformation? Mutation sounds very general > > and could encapsulate things like addition / subtraction, which we already > > support. > > > > We'll need to expose this in order to allow the allocator to update > > resources as well. Do you think this would benefit from being first class > > in resources.hpp?
Moved to Resources. I still wanna keep AcquirePersistentVolume in master as it's quite specific to master. > On Dec. 13, 2014, 1:21 a.m., Ben Mahler wrote: > > src/master/master.cpp, lines 1854-1858 > > <https://reviews.apache.org/r/28720/diff/2/?file=783822#file783822line1854> > > > > Hm.. we might want to document the "idempotent" nature of this > > operation at the top level of this class. Done. > On Dec. 13, 2014, 1:21 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 1865 > > <https://reviews.apache.org/r/28720/diff/2/?file=783822#file783822line1865> > > > > Yikes! Could we match the wrong role here? Shouldn't we be looking for > > a role match? Good catch! > On Dec. 13, 2014, 1:21 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 1850 > > <https://reviews.apache.org/r/28720/diff/2/?file=783822#file783822line1850> > > > > Do you need to be validating disk? Does it work if has_disk() == false? Added a CHECK. > On Dec. 13, 2014, 1:21 a.m., Ben Mahler wrote: > > src/master/master.cpp, lines 1813-1814 > > <https://reviews.apache.org/r/28720/diff/2/?file=783822#file783822line1813> > > > > Maybe "sequence" is a better word than "series"? > > > > Do we need the reference to the composite pattern wikipedia page? Seems > > very straightforward (and the wikipedia page is quite big) :) Done. > On Dec. 13, 2014, 1:21 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 1830 > > <https://reviews.apache.org/r/28720/diff/2/?file=783822#file783822line1830> > > > > could we do s/_result/applied/ or s/_result/apply ? Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28720/#review65007 ----------------------------------------------------------- On Dec. 13, 2014, 5:58 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28720/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2014, 5:58 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2030 > https://issues.apache.org/jira/browse/MESOS-2030 > > > Repository: mesos-git > > > Description > ------- > > Introduced an abstraction for mutating resources. Acquiring persistent disk > is one type of resources mutation. > > Infer persistent disk acquisitions from resources and check resource usage > against adjusted total resources. > > Adjusted the calculation of unused resources in _launchTasks by considering > persistent disk acquisition. > > > Diffs > ----- > > src/master/master.cpp 0f55a5cc2d6845cbaace718a48f771d80aad0e6e > src/tests/resource_offers_tests.cpp > e13b6c5460d9e6729843c40bed9e4d4e3f76d5d3 > > Diff: https://reviews.apache.org/r/28720/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
