> On Dec. 16, 2014, 9:59 p.m., Ben Mahler wrote: > > src/common/resources.cpp, lines 922-930 > > <https://reviews.apache.org/r/28720/diff/5/?file=793223#file793223line922> > > > > Duplicate persistence IDs are allowed across roles? Is that handled > > everywhere else in the code?
Yes. It's handled. Also, see include/mesos/mesos.proto > On Dec. 16, 2014, 9:59 p.m., Ben Mahler wrote: > > src/common/resources.cpp, line 928 > > <https://reviews.apache.org/r/28720/diff/5/?file=793223#file793223line928> > > > > Can we include the ID? Done. > On Dec. 16, 2014, 9:59 p.m., Ben Mahler wrote: > > src/common/resources.cpp, line 909 > > <https://reviews.apache.org/r/28720/diff/5/?file=793223#file793223line909> > > > > How about splitting these checks? > > > > ``` > > CHECK(disk.has_disk()); > > CHECK(disk.disk().has_persistence()); > > ``` Done. > On Dec. 16, 2014, 9:59 p.m., Ben Mahler wrote: > > src/common/resources.cpp, lines 946-947 > > <https://reviews.apache.org/r/28720/diff/5/?file=793223#file793223line946> > > > > How about `stripped` or `strippedDisk`? Might be a bit easier to read. Done. > On Dec. 16, 2014, 9:59 p.m., Ben Mahler wrote: > > src/common/resources.cpp, line 958 > > <https://reviews.apache.org/r/28720/diff/5/?file=793223#file793223line958> > > > > How about: > > > > ``` > > return Error("Insufficient disk resources"); > > ``` Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28720/#review65237 ----------------------------------------------------------- On Dec. 16, 2014, 9:11 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28720/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2014, 9:11 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2030 > https://issues.apache.org/jira/browse/MESOS-2030 > > > Repository: mesos-git > > > Description > ------- > > Introduced an abstraction for mutating resources. Acquiring persistent disk > is one type of resources mutation. > > Infer persistent disk acquisitions from resources and check resource usage > against adjusted total resources. > > Adjusted the calculation of unused resources in _launchTasks by considering > persistent disk acquisition. > > > Diffs > ----- > > include/mesos/resources.hpp 296553af93ec8457dad04ac018f03f36df654fdc > src/common/resources.cpp 9bf7ae9148d6db2829cc2866ac048fe018ae2c92 > src/master/master.cpp 0f55a5cc2d6845cbaace718a48f771d80aad0e6e > src/tests/resource_offers_tests.cpp > e13b6c5460d9e6729843c40bed9e4d4e3f76d5d3 > > Diff: https://reviews.apache.org/r/28720/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
