> On Dec. 18, 2014, 2:31 a.m., Ben Mahler wrote: > > src/master/master.cpp, lines 1897-1902 > > <https://reviews.apache.org/r/28720/diff/7/?file=795193#file795193line1897> > > > > Ah, we should consider how to make these unit testable, since > > ResourceValidator doesn't actually need Framework and Slave. > > > > Let's punt for now, but this seems like a pretty dangerous area since > > we're not going to write big integration tests to catch all the cases. I > > can think about this. > > > > Commented on > > [MESOS-1064](https://issues.apache.org/jira/browse/MESOS-1064) > > > > One idea was to pull out validators as a series of functions, when we > > compose validators we bind in the appropriate arugments. This means not all > > validators need to take the same arguments, but we can invoke them through > > a no-argument function operator, since they have everything bound in > > already.
+1, also added to [MESOS-1064](https://issues.apache.org/jira/browse/MESOS-1064) - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28720/#review65422 ----------------------------------------------------------- On Dec. 17, 2014, 11:09 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28720/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 11:09 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2030 > https://issues.apache.org/jira/browse/MESOS-2030 > > > Repository: mesos-git > > > Description > ------- > > Introduced an abstraction for mutating resources. Acquiring persistent disk > is one type of resources mutation. > > Infer persistent disk acquisitions from resources and check resource usage > against adjusted total resources. > > Adjusted the calculation of unused resources in _launchTasks by considering > persistent disk acquisition. > > > Diffs > ----- > > src/master/master.cpp 0f55a5cc2d6845cbaace718a48f771d80aad0e6e > src/tests/resource_offers_tests.cpp > e13b6c5460d9e6729843c40bed9e4d4e3f76d5d3 > > Diff: https://reviews.apache.org/r/28720/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
