> On Dec. 18, 2014, 2:31 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 2083 > > <https://reviews.apache.org/r/28720/diff/7/?file=795193#file795193line2083> > > > > Would love to have a test for this case! :) > > Jie Yu wrote: > Sure.
Well, I ended up adding a TODO (will do it in https://reviews.apache.org/r/28886/) because it requires constructing an offered resource with a persistence ID which is easier if we can launch the task (with ID) and later kill it. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28720/#review65422 ----------------------------------------------------------- On Dec. 17, 2014, 11:09 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28720/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 11:09 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2030 > https://issues.apache.org/jira/browse/MESOS-2030 > > > Repository: mesos-git > > > Description > ------- > > Introduced an abstraction for mutating resources. Acquiring persistent disk > is one type of resources mutation. > > Infer persistent disk acquisitions from resources and check resource usage > against adjusted total resources. > > Adjusted the calculation of unused resources in _launchTasks by considering > persistent disk acquisition. > > > Diffs > ----- > > src/master/master.cpp 0f55a5cc2d6845cbaace718a48f771d80aad0e6e > src/tests/resource_offers_tests.cpp > e13b6c5460d9e6729843c40bed9e4d4e3f76d5d3 > > Diff: https://reviews.apache.org/r/28720/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
