> On Dec. 6, 2014, 12:05 a.m., Niklas Nielsen wrote: > > src/authentication/cram_md5/authenticator.hpp, line 22 > > <https://reviews.apache.org/r/27760/diff/7/?file=766648#file766648line22> > > > > Why was this not a problem before? I don't see size_t in your review > > elsewhere?
size_t is being used by sasl.h as noted in that comment :) > On Dec. 6, 2014, 12:05 a.m., Niklas Nielsen wrote: > > src/authentication/cram_md5/authenticator.hpp, line 539 > > <https://reviews.apache.org/r/27760/diff/7/?file=766648#file766648line539> > > > > Why can we remove this? Because the process instance is now generated within the constructor. > On Dec. 6, 2014, 12:05 a.m., Niklas Nielsen wrote: > > src/master/master.cpp, lines 3953-3954 > > <https://reviews.apache.org/r/27760/diff/7/?file=766650#file766650line3953> > > > > Wrap around '=' and 4 space indent 2 spaces, right? > On Dec. 6, 2014, 12:05 a.m., Niklas Nielsen wrote: > > src/master/master.cpp, lines 429-430 > > <https://reviews.apache.org/r/27760/diff/7/?file=766650#file766650line429> > > > > Wrap around '=' and bring lines down to 4 spaces. > > This can be const too, right? Ow, its two spaces according to our styleguide. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review64116 ----------------------------------------------------------- On Dec. 19, 2014, 6:22 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27760/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2014, 6:22 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos-git > > > Description > ------- > > The initial design and implementation of the authenticator module interface > caused issues and was not optimal for heavy lifting setup of external > dependencies. By introducing a two fold design, this has been decoupled from > the authentication message processing. The new design also gets us back on > track to the goal of makeing SASL a soft dependency of mesos. > > > Diffs > ----- > > src/authentication/authenticator.hpp 460494a > src/authentication/cram_md5/authenticator.hpp d739a02 > src/master/master.hpp 26116af > src/master/master.cpp 0c98b51 > src/tests/cram_md5_authentication_tests.cpp a356aa1 > > Diff: https://reviews.apache.org/r/27760/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
