----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ -----------------------------------------------------------
(Updated Dec. 20, 2014, 12:41 a.m.) Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. Changes ------- Addressed Adam's comments. Bugs: MESOS-2050 https://issues.apache.org/jira/browse/MESOS-2050 Repository: mesos-git Description ------- The initial design and implementation of the authenticator module interface caused issues and was not optimal for heavy lifting setup of external dependencies. By introducing a two fold design, this has been decoupled from the authentication message processing. The new design also gets us back on track to the goal of makeing SASL a soft dependency of mesos. Diffs (updated) ----- src/authentication/authenticator.hpp 460494a src/authentication/cram_md5/authenticator.hpp d739a02 src/master/master.hpp 26116af src/master/master.cpp 0c98b51 src/tests/cram_md5_authentication_tests.cpp a356aa1 Diff: https://reviews.apache.org/r/27760/diff/ Testing ------- make check Thanks, Till Toenshoff