----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review65703 -----------------------------------------------------------
Ship it! Looks great! Just a few more comments/log messages to reword. src/master/master.cpp <https://reviews.apache.org/r/27760/#comment108910> s/non authenticating/non-authenticating/ src/master/master.cpp <https://reviews.apache.org/r/27760/#comment108909> "Authentication is not usable:" sounds too harsh/vague. How about "Authentication is disabled:" src/master/master.cpp <https://reviews.apache.org/r/27760/#comment108915> We use @param in at least a couple of src/linux/ c++ files, and may do more with doxygen in the future, so how about: `// @param from The authenticatee process with which to communicate.` `// @param pid The framework/slave process being authenticated.` src/tests/cram_md5_authentication_tests.cpp <https://reviews.apache.org/r/27760/#comment108916> s/initializing/initialization/ - Adam B On Dec. 19, 2014, 10:22 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27760/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2014, 10:22 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos-git > > > Description > ------- > > The initial design and implementation of the authenticator module interface > caused issues and was not optimal for heavy lifting setup of external > dependencies. By introducing a two fold design, this has been decoupled from > the authentication message processing. The new design also gets us back on > track to the goal of makeing SASL a soft dependency of mesos. > > > Diffs > ----- > > src/authentication/authenticator.hpp 460494a > src/authentication/cram_md5/authenticator.hpp d739a02 > src/master/master.hpp 26116af > src/master/master.cpp 0c98b51 > src/tests/cram_md5_authentication_tests.cpp a356aa1 > > Diff: https://reviews.apache.org/r/27760/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
