> On Dec. 19, 2014, 2:05 a.m., Adam B wrote: > > include/mesos/resources.hpp, lines 111-112 > > <https://reviews.apache.org/r/28698/diff/2/?file=793361#file793361line111> > > > > Should this be updated to be a `hashmap<role, hashmap<reservation, > > Resources>>`? Or is it good enough to leave this hashmap only partitioned > > by role?
This one was added by Ben Mahler, and it doesn't actually get used anywhere in the codebase except for in a test currently. Having said that, I think we can keep the current API for now. We can simply switch on `STATIC/DYNAMIC` if we want a specific reservation or maybe decide to change it later. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28698/#review65561 ----------------------------------------------------------- On Dec. 30, 2014, 10:12 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28698/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2014, 10:12 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Modified Resources to account for reservation type. > > > Diffs > ----- > > include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f > src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e > > Diff: https://reviews.apache.org/r/28698/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
