> On Dec. 19, 2014, 2:05 a.m., Adam B wrote: > > include/mesos/resources.hpp, lines 64-69 > > <https://reviews.apache.org/r/28698/diff/2/?file=793361#file793361line64> > > > > Does this always assume STATIC? Shouldn't you be able to parse a string > > into name/value/role while also specifying the reservation type? > > Michael Park wrote: > This one was intentionally put off for 2 reasons. > 1. We would have to change the syntax for resources. Current syntax is > "name(role):value;...", how should we introduce the dynamic reservation > there? perhaps "name[role]:value"? I mentioned this to Tim Chen and he > suggested maybe we just ditch this and resort to a JSON format or something > more explicit. > 2. I don't think we quite want to allow slave resources on the command > line to include dynamic reservations. If we allow dynamic reservations to be > specified here, we would have to explicitly check for this in the command > line and maybe other places we want to disallow it. > > Adam B wrote: > Fair enough. So how would it be checkpointed and recovered? JSON > ser/deserialization of the protobuf? > > Michael Park wrote: > Oh heh that's a good point. I was deferring checkpointing issues to Jie > so I probably would've ran into this issue with him later on.. Let me sync > with him on that. Thanks for bringing it up :)
Looked into the resources recovery code, and found that we use `ResourcesState::recover` function, in which we use `::protobuf::read<Resource>` to read the `Resource` object stored on the checkpoint file. I don't know whether the format stored on the checkpoint file but I do know that we don't use the `Resources::parse` function which is what we care about :) - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28698/#review65561 ----------------------------------------------------------- On Dec. 31, 2014, 9:52 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28698/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2014, 9:52 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Modified Resources to account for reservation type. > > > Diffs > ----- > > include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f > src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e > > Diff: https://reviews.apache.org/r/28698/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
