> On Dec. 19, 2014, 2:05 a.m., Adam B wrote: > > src/common/resources.cpp, lines 456-467 > > <https://reviews.apache.org/r/28698/diff/2/?file=793362#file793362line456> > > > > I'd agree that ignoring reservations and returning all resources for > > that role makes sense, although it seems `Resources::reserved` is only > > called twice, once in allocate() where you wouldn't care what kind of > > reservation it is (and do want to include dynamic reservations), and once > > in Filter, where you are explicitly adding the reservation type in your > > patch. > > I doubt that anybody is using `reserved(role)` in their frameworks, but > > maybe they'd appreciate a note in the upgrades doc.
`reserved(role)` is new from https://reviews.apache.org/r/28985 so I don't think anyone could've been using it in their frameworks. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28698/#review65561 ----------------------------------------------------------- On Dec. 30, 2014, 10:12 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28698/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2014, 10:12 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Modified Resources to account for reservation type. > > > Diffs > ----- > > include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f > src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e > > Diff: https://reviews.apache.org/r/28698/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
