> On Dec. 16, 2014, 11:52 p.m., Michael Park wrote: > > src/common/resources.cpp, lines 456-467 > > <https://reviews.apache.org/r/28698/diff/2/?file=793362#file793362line456> > > > > What should be the default behaviour for functions like > > `reserved(role)`? > > 1. Return resources with the same role, ignoring reservations, or > > 2. Return resources with the same role and set reservation to be > > STATIC by default. > > > > I've implemented 1 here because I believe it's a better API but I'm > > wondering if it has backwards-compatibility issues.
Going with 1. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28698/#review65258 ----------------------------------------------------------- On Dec. 30, 2014, 11:51 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28698/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2014, 11:51 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Modified Resources to account for reservation type. > > > Diffs > ----- > > include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f > src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e > > Diff: https://reviews.apache.org/r/28698/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
