----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29535/#review66600 -----------------------------------------------------------
Ship it! LGTM, but you could add simple unit tests for (not) repairing discarded/ready futures. 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/29535/#comment110181> Unrelated, but appreciated documentation update. :) 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/29535/#comment110184> Any reason why internal::repair places the lambda parameter before the promise, and internal::thenf reverses the order? 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/29535/#comment110185> Maybe worth making a private helper function here, since it's already repeated so many times. 3rdparty/libprocess/src/tests/process_tests.cpp <https://reviews.apache.org/r/29535/#comment110180> Shouldn't you also test that the repair callback is skipped if the future succeeds or is discarded? - Adam B On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29535/ > ----------------------------------------------------------- > > (Updated Jan. 1, 2015, 8:46 p.m.) > > > Review request for mesos and Adam B. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 0326b23cdd475c6e86b33f9b4c63136fdecab443 > 3rdparty/libprocess/src/tests/process_tests.cpp > 3bbfe0a7a65acb52d139fda81816acf305d891f5 > > Diff: https://reviews.apache.org/r/29535/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
