> On Jan. 8, 2015, 11:27 a.m., Bernd Mathiske wrote: > > src/docker/executor.cpp, line 189 > > <https://reviews.apache.org/r/29329/diff/1/?file=798951#file798951line189> > > > > This stems from copied code. Any ideas how to do this properly?
We probably need to add some visibility under libprocess, or perhaps a send that returns a future that we want wait on. Either way, it's a TODO that should be fixed altogether with other executors in another review. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/#review67035 ----------------------------------------------------------- On Jan. 6, 2015, 10:16 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29329/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 10:16 p.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Repository: mesos-git > > > Description > ------- > > Add executor for docker containerizer, replaces the usage of command executor > > > Diffs > ----- > > src/Makefile.am 6f132b5a66e117c2a907763217bfafe1fce1b7a0 > src/docker/executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29329/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
