----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29335/#review67456 -----------------------------------------------------------
src/slave/containerizer/docker.hpp <https://reviews.apache.org/r/29335/#comment111490> This character could be declared at a central place, perhaps inside the below-mentioned function or as a #define preceeding the latter, together with DOCKER_NAME_PREFIX. src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/29335/#comment111481> At this point, after seeing so many copies of this code, I am fairly convinced that a function for container name construction with parameters slaveID and containerId should be defined somewhere and then called here and everywhere else. Spreading copies of this concatenation around looks brittle. src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/29335/#comment111483> Here is an opportunity to call the above mentioned containerName function. - Bernd Mathiske On Jan. 8, 2015, 5:24 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29335/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 5:24 p.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Repository: mesos-git > > > Description > ------- > > Fix docker container naming and tests. > "." is an illegal character for docker containers, replacing it with "/" > > > Diffs > ----- > > src/slave/containerizer/docker.hpp b7bf54a > src/slave/containerizer/docker.cpp 5f4b4ce > src/tests/docker_containerizer_tests.cpp 2105ae2 > > Diff: https://reviews.apache.org/r/29335/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
