> On Feb. 14, 2015, 3:31 p.m., Till Toenshoff wrote: > > src/slave/containerizer/docker.hpp, line 38 > > <https://reviews.apache.org/r/29335/diff/4/?file=824298#file824298line38> > > > > s/name/names/ ?
name here is a single container name I'm referring to. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29335/#review72499 ----------------------------------------------------------- On Jan. 17, 2015, 1:36 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29335/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2015, 1:36 a.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Repository: mesos > > > Description > ------- > > Fix docker container naming and tests. > "." is an illegal character for docker containers, replacing it with "/" > > > Diffs > ----- > > src/slave/containerizer/docker.hpp b7bf54a > src/slave/containerizer/docker.cpp 5f4b4ce > src/tests/docker_containerizer_tests.cpp 2105ae2 > > Diff: https://reviews.apache.org/r/29335/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
