----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29335/#review72499 -----------------------------------------------------------
There are some changes in here that do not seem to match the review description. Would you mind taking a look, and if needed, adapt the review description? src/slave/containerizer/docker.hpp <https://reviews.apache.org/r/29335/#comment118548> s/name/names/ ? src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29335/#comment118549> How is this change related to the naming scheme update? src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/29335/#comment118550> const string mame& ? src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/29335/#comment118551> const ref? src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/29335/#comment118552> Why can we get rid of this and the two removed, following hunks (#1238-1241, #1244-1245)? src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/29335/#comment118553> const ref? src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/29335/#comment118554> const ref? - Till Toenshoff On Jan. 17, 2015, 1:36 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29335/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2015, 1:36 a.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Repository: mesos > > > Description > ------- > > Fix docker container naming and tests. > "." is an illegal character for docker containers, replacing it with "/" > > > Diffs > ----- > > src/slave/containerizer/docker.hpp b7bf54a > src/slave/containerizer/docker.cpp 5f4b4ce > src/tests/docker_containerizer_tests.cpp 2105ae2 > > Diff: https://reviews.apache.org/r/29335/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
