> On Jan. 15, 2015, 5:28 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 3890 > > <https://reviews.apache.org/r/28656/diff/9/?file=820347#file820347line3890> > > > > Why pull this into a static method instead of doing it inline? > > > > Also, shouldn't this be guarded by 'flags.hooks.isSome()' ?
It's require a non-const copy of ExecutorInfo to decorate the environment variables. However, we want to preserve the const-ness of the variable executorInfo for safety purposes. So, this was thought of a safer alternative. If there are strong concerns about inline vs static function, I guess we can change it. The second point is a valid point. I'll create a new review request to take care of that. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28656/#review68335 ----------------------------------------------------------- On Jan. 13, 2015, 8:31 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28656/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 8:31 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-2060 > https://issues.apache.org/jira/browse/MESOS-2060 > > > Repository: mesos-git > > > Description > ------- > > Similar to label decorator for Master. > > > Diffs > ----- > > src/hook/hook.hpp PRE-CREATION > src/hook/manager.hpp PRE-CREATION > src/hook/manager.cpp PRE-CREATION > src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6 > src/slave/main.cpp 2ff2b0d186dd63e1437956e98e3682d83f2f5cd6 > src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d > > Diff: https://reviews.apache.org/r/28656/diff/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
