> On Jan. 13, 2015, 5:35 p.m., Niklas Nielsen wrote: > > src/hook/manager.cpp, lines 104-105 > > <https://reviews.apache.org/r/28656/diff/5/?file=819528#file819528line104> > > > > Similar, can we make this an option type?
Updated design doesn't require the bool. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28656/#review67960 ----------------------------------------------------------- On Jan. 13, 2015, 7:36 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28656/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 7:36 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-2060 > https://issues.apache.org/jira/browse/MESOS-2060 > > > Repository: mesos-git > > > Description > ------- > > Similar to label decorator for Master. > > > Diffs > ----- > > src/hook/hook.hpp PRE-CREATION > src/hook/manager.hpp PRE-CREATION > src/hook/manager.cpp PRE-CREATION > src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6 > src/slave/main.cpp 2ff2b0d186dd63e1437956e98e3682d83f2f5cd6 > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d > > Diff: https://reviews.apache.org/r/28656/diff/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
